[PATCH v5] app/testpmd: add help messages for multi-process

[Ferruh Yigit]

On 6/2/2022 3:24 AM, Min Hu (Connor) wrote:
> Hi, all,
>     any comments?
> 
> 在 2022/3/7 9:04, Min Hu (Connor) 写道:
>> From: Huisong Li <lihuisong at huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs=N: set the total number of multi-process instances
>> --proc-id=id:  set the id of the current process from multi-process
>> instances(0 <= id < num-procs)
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong at huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>> ---
>> v6:
>> * fix comments.
>> v5:
>> * delete space
>> v4:
>> * update description for parameters.
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..2834e9e180 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,9 @@ usage(char* progname)
>>              "extended statistics to show. Used with --stats-period "
>>              "specified or interactive commands that show Rx/Tx 
>> statistics "
>>              "(i.e. 'show port stats').\n");
>> +    printf("  --num-procs=N: set the total number of multi-process 
>> instances\n");
>> +    printf("  --proc-id=id:  set the id of the current process from 
>> multi-process instances\n"
>> +           "(0 <= id < num-procs).\n");
>>       printf("  --nb-cores=N: set the number of forwarding cores "
>>              "(1 <= N <= %d).\n", nb_lcores);
>>       printf("  --nb-ports=N: set the number of forwarding ports "
>>

Hi Connor,

output is as following [1], is "(0 <= id < num-procs)." part break into 
next line intentionally? This breaks the output.

I assume the line is broken in source code to fit into line length, but 
it doesn't have to break the line in output, what do you think?


[1]
...
   --num-procs=N: set the total number of multi-process instances
   --proc-id=id:  set the id of the current process from multi-process ..
(0 <= id < num-procs).
   --nb-cores=N: set the number of forwarding cores (1 <= N <= 55).
...