[PATCH v2] net/igc: add I226 support

Thomas Monjalon thomas at monjalon.net
Mon Jun 6 13:45:43 CEST 2022


06/06/2022 12:54, Zhang, Qi Z:
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas at monjalon.net>
> > Sent: Monday, June 6, 2022 6:49 PM
> > To: Yang, Qiming <qiming.yang at intel.com>; Zhang, Qi Z
> > <qi.z.zhang at intel.com>
> > Cc: dev at dpdk.org; Liu, KevinX <kevinx.liu at intel.com>
> > Subject: Re: [PATCH v2] net/igc: add I226 support
> > 
> > 06/06/2022 01:12, Zhang, Qi Z:
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon <thomas at monjalon.net>
> > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > To: Zhang, Qi Z <qi.z.zhang at intel.com>; Yang, Qiming
> > > > <qiming.yang at intel.com>
> > > > Cc: dev at dpdk.org; Liu, KevinX <kevinx.liu at intel.com>
> > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > >
> > > > 25/05/2022 07:57, Qiming Yang:
> > > > > Added I226 Series device ID in igc driver and updated igc guide
> > > > > document for new devices.
> > > > >
> > > > > Signed-off-by: Qiming Yang <qiming.yang at intel.com>
> > > > > Signed-off-by: Kevin Liu <kevinx.liu at intel.com>
> > > > > ---
> > > > > v2:
> > > > > * rebased
> > > > > ---
> > > > >  doc/guides/nics/igc.rst                | 14 +++++++-------
> > > > >  doc/guides/rel_notes/release_22_03.rst |  5 +++++
> > > >
> > > > You are sending a patch after 22.03 is closed, so it should be listed in
> > 22.07!
> > > >
> > > > I will fix while pulling the tree prepared by Qi.
> > > > Please be more careful with the basic checks.
> > >
> > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > A new version is required.
> > 
> > Too late, it is in the main tree with release notes fixed.
> > Do you need more fix?
> 
> OK, I guess we need to revert it with a new fix.
> Sorry for the chaos...

Why revert? If there is a bug, just fix it.





More information about the dev mailing list