[PATCH] eal: remove unused arch specific headers for locks
Stephen Hemminger
stephen at networkplumber.org
Tue Jun 7 22:34:30 CEST 2022
On Tue, 7 Jun 2022 21:03:08 +0200
David Marchand <david.marchand at redhat.com> wrote:
> MCS lock, PF lock and Ticket lock have no arch specific implementation,
> there is no need for the extra redirection in headers.
>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
> Note: this was mentionned during the seqlock patch review, and I spotted
> it again, while reviewing the RISC-V port, and I see the same for a next
> architecture too. So better clean this up as we don't need the
> redirection.
>
> ---
> MAINTAINERS | 4 ++--
> lib/eal/arm/include/meson.build | 3 ---
> lib/eal/arm/include/rte_mcslock.h | 22 -------------------
> lib/eal/arm/include/rte_pflock.h | 18 ---------------
> lib/eal/arm/include/rte_ticketlock.h | 22 -------------------
> lib/eal/include/meson.build | 6 ++---
> lib/eal/include/{generic => }/rte_mcslock.h | 8 +++++++
> lib/eal/include/{generic => }/rte_pflock.h | 0
> .../include/{generic => }/rte_ticketlock.h | 0
> lib/eal/ppc/include/meson.build | 3 ---
> lib/eal/ppc/include/rte_mcslock.h | 18 ---------------
> lib/eal/ppc/include/rte_pflock.h | 17 --------------
> lib/eal/ppc/include/rte_ticketlock.h | 18 ---------------
> lib/eal/x86/include/meson.build | 3 ---
> lib/eal/x86/include/rte_mcslock.h | 18 ---------------
> lib/eal/x86/include/rte_pflock.h | 18 ---------------
> lib/eal/x86/include/rte_ticketlock.h | 18 ---------------
> 17 files changed, 13 insertions(+), 183 deletions(-)
> delete mode 100644 lib/eal/arm/include/rte_mcslock.h
> delete mode 100644 lib/eal/arm/include/rte_pflock.h
> delete mode 100644 lib/eal/arm/include/rte_ticketlock.h
> rename lib/eal/include/{generic => }/rte_mcslock.h (98%)
> rename lib/eal/include/{generic => }/rte_pflock.h (100%)
> rename lib/eal/include/{generic => }/rte_ticketlock.h (100%)
> delete mode 100644 lib/eal/ppc/include/rte_mcslock.h
> delete mode 100644 lib/eal/ppc/include/rte_pflock.h
> delete mode 100644 lib/eal/ppc/include/rte_ticketlock.h
> delete mode 100644 lib/eal/x86/include/rte_mcslock.h
> delete mode 100644 lib/eal/x86/include/rte_pflock.h
> delete mode 100644 lib/eal/x86/include/rte_ticketlock.h
>
Looks great will make future work easier.
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
More information about the dev
mailing list