[PATCH] dma/idxd: fix return value for pci device commands

Kevin Laatz kevin.laatz at intel.com
Wed Jun 8 10:57:18 CEST 2022


On 08/06/2022 09:54, Thomas Monjalon wrote:
> 07/06/2022 12:56, Walsh, Conor:
>>> Subject: [PATCH] dma/idxd: fix return value for pci device commands
>>>
>>> When sending a command to an idxd device via pci bar, the response from
>>> HW is checked to ensure it was successful. The response was incorrectly
>>> being negated before being returned by the function, meaning error codes
>>> cannot be checked against the HW specification.
>>>
>>> This patch fixes the return values of the function by removing the
>>> negation.
>>>
>>> Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
>> Acked-by: Conor Walsh <conor.walsh at intel.com>
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
> Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check")
> Cc: stable at dpdk.org
>
> Please don't forget above lines in future.
>
> Applied, thanks.
>
That was an oversight, thanks for adding!



More information about the dev mailing list