[PATCH v2] devtools: ensure proper tag sequence
Thomas Monjalon
thomas at monjalon.net
Wed Jun 15 08:20:31 CEST 2022
14/06/2022 00:21, jpalider at marvell.com:
> + SEQ[0] = "Coverity issue";
> + SEQ[1] = "Bugzilla ID";
> + SEQ[2] = "Fixes";
> + SEQ[3] = "Cc";
> + SEQ[4] = "^$";
> + SEQ[5] = "Suggested-by";
> + SEQ[6] = "Reported-by";
> + SEQ[7] = "Signed-off-by";
> + latest = 0;
Do you think you could check that Review, Ack and Test are added
after the first Signed-off?
> +Tag order
> +~~~~~~~~~
> +
> +There is a pattern indicating how certain tags should relate to each other.
> +
> +Example of proper tag sequence::
> +
> + Coverity issue:
> + Bugzilla ID:
> + Fixes:
> + Cc:
> +
> + Suggested-by:
> + Reported-by:
> + Signed-off-by:
Given it is an example, you could add Reviewed-by, Acked-by and Tested-by.
> +
> +Between first and second tag section there is and empty line.
> +
> +While ``Signed-off-by:`` is an obligatory tag and must exists in each commit,
> +all other tags are optional. Any tag, as long as it is in proper location
> +to other adjacent tags (if present), may occur multiple times.
> +
> +Other tags shall be laid out in a chronological order.
Yes, after the first Signed-off-by.
More information about the dev
mailing list