[PATCH v2] net/mlx5: fix build with clang 14

David Marchand david.marchand at redhat.com
Wed Jun 15 10:41:23 CEST 2022


On Wed, Jun 15, 2022 at 10:17 AM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> 11/05/2022 18:41, Ali Alnubani:
> > Use fgets instead of fscanf to resolve the following warning
> > reported by clang 14.0.0 in Fedora 37 (Rawhide):
> >
> > drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error:
> >   'fscanf' may overflow; destination buffer in argument 3 has size 16,
> >   but the corresponding specifier may require size 17
> >   [-Werror,-Wfortify-source]
> >   ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
>
> Some other patches are proposing to declare the variable
> of size IF_NAMESIZE+1 but I think it's wrong because
> IF_NAMESIZE includes a terminating null byte.

Ack, I rejected my patch accordingly.


-- 
David Marchand



More information about the dev mailing list