[PATCH v8 1/4] ethdev: support device error recovery notification

[fengchengwen]

Hi Thomas,

On 2022/6/21 1:42, Thomas Monjalon wrote:
> 16/06/2022 11:41, Chengwen Feng:
>> --- a/lib/ethdev/rte_ethdev.h
>> +++ b/lib/ethdev/rte_ethdev.h
>> @@ -3928,6 +3928,12 @@ enum rte_eth_event_type {
>>  	 * @see rte_eth_rx_avail_thresh_set()
>>  	 */
>>  	RTE_ETH_EVENT_RX_AVAIL_THRESH,
>> +	/** Port recovering from a hardware or firmware error */
>> +	RTE_ETH_EVENT_ERR_RECOVERING,
>> +	/** Port recovers successful from the error */
>> +	RTE_ETH_EVENT_RECOVER_SUCCESS,
>> +	/** Port recovers failed from the error */
>> +	RTE_ETH_EVENT_RECOVER_FAILED,
>>  	RTE_ETH_EVENT_MAX       /**< max value of this enum */
>>  };
> 
> The descriptions here are not enough.
> We cannot understand what has changed on the port,
> and which action must be taken.

There are detail descriptions in /doc/guides/prog_guide/poll_mode_drv.rst,
I will add your review in poll_mode_drv.rst.

Another question: do we need to add a detail description here as well? I think the poll_mode_drv.rst is enough.

> 
> Note: I believe that's the same problem from the beginning:
> we need a generic handling which is described in details.
> 
> 
> 
> .
>