[PATCH v3 12/13] net/nfp: nfdk packet xmit function

[Ferruh Yigit]

On 6/22/2022 5:03 PM, Thomas Monjalon wrote:
> 17/06/2022 11:34, Jin Liu:
>> +		if (unlikely(pkt->nb_segs > 1 &&
>> +				!(hw->cap & NFP_NET_CFG_CTRL_GATHER))) {
>> +			PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set");
>> +			rte_panic("Multisegment packet unsupported\n");
>> +		}
> [...]
>> +		if (round_down(txq->wr_p, NFDK_TX_DESC_BLOCK_CNT) !=
>> +			round_down(txq->wr_p + used_descs - 1, NFDK_TX_DESC_BLOCK_CNT)) {
>> +			rte_panic("Used descs cross block boundary\n");
>> +		}
> 
> You cannot use rte_panic in a driver or library.
> It will make the user experience terrible.
> If there is a failure, please log an error and return appropriately.
> 
> There is a check in the CI to avoid such use:
> https://patches.dpdk.org/project/dpdk/patch/20220617093444.2004000-13-jin.liu@corigine.com/
> https://mails.dpdk.org/archives/test-report/2022-June/290206.html
> 
> It seems you've ignored this critical warning.
> 
> I don't want to let new occurences of rte_panic enter in drivers,
> so I'll drop this patch from the main branch.
> Please re-submit without rte_panic.
> 
> 

I also missed it, dropping patch from next-net.