[PATCH 3/3] dmap/dpaa2: remove unnecessary null check

Stephen Hemminger stephen at networkplumber.org
Wed Jun 22 20:51:58 CEST 2022


The function rte_free already handles being called with NULL.
Found by nullfree.cocci.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c
index a93a60565df7..0500e8c22590 100644
--- a/drivers/dma/dpaa2/dpaa2_qdma.c
+++ b/drivers/dma/dpaa2/dpaa2_qdma.c
@@ -1404,11 +1404,9 @@ dpaa2_qdma_reset(struct rte_dma_dev *dev)
 
 	/* Reset and free virtual queues */
 	for (i = 0; i < qdma_dev->num_vqs; i++) {
-		if (qdma_dev->vqs[i].status_ring)
-			rte_ring_free(qdma_dev->vqs[i].status_ring);
+		rte_ring_free(qdma_dev->vqs[i].status_ring);
 	}
-	if (qdma_dev->vqs)
-		rte_free(qdma_dev->vqs);
+	rte_free(qdma_dev->vqs);
 	qdma_dev->vqs = NULL;
 
 	/* Reset QDMA device structure */
-- 
2.35.1



More information about the dev mailing list