[EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count

[Rahul Bhansali]

Ping.

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Thursday, June 2, 2022 1:19 PM
> To: Rahul Bhansali <rbhansali at marvell.com>
> Cc: dpdk-dev <dev at dpdk.org>; Bruce Richardson
> <bruce.richardson at intel.com>; Thomas Monjalon <thomas at monjalon.net>;
> Ferruh Yigit <ferruh.yigit at xilinx.com>; Ajit Khaparde
> <ajit.khaparde at broadcom.com>; Andrew Boyer <aboyer at pensando.io>;
> Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>; Beilei Xing
> <beilei.xing at intel.com>; Chas Williams <chas3 at att.com>; Xia, Chenbo
> <chenbo.xia at intel.com>; Ciara Loftus <ciara.loftus at intel.com>; Devendra
> Singh Rawat <dsinghrawat at marvell.com>; Ed Czeck
> <ed.czeck at atomicrules.com>; Evgeny Schemeilin <evgenys at amazon.com>;
> Gaetan Rivet <grive at u256.net>; Gagandeep Singh <g.singh at nxp.com>;
> Guoyang Zhou <zhouguoyang at huawei.com>; Haiyue Wang
> <haiyue.wang at intel.com>; Harman Kalra <hkalra at marvell.com>;
> heinrich.kuhn at corigine.com; Hemant Agrawal <hemant.agrawal at nxp.com>;
> Hyong Youb Kim <hyonkim at cisco.com>; Igor Chauskin <igorch at amazon.com>;
> Igor Russkikh <irusskikh at marvell.com>; Jakub Grajciar <jgrajcia at cisco.com>;
> Jasvinder Singh <jasvinder.singh at intel.com>; Jian Wang
> <jianwang at trustnetic.com>; Jiawen Wu <jiawenwu at trustnetic.com>; Jingjing
> Wu <jingjing.wu at intel.com>; John Daley <johndale at cisco.com>; John Miller
> <john.miller at atomicrules.com>; John W. Linville <linville at tuxdriver.com>;
> Wiles, Keith <keith.wiles at intel.com>; Kiran Kumar Kokkilagadda
> <kirankumark at marvell.com>; Lijun Ou <oulijun at huawei.com>; Liron Himi
> <lironh at marvell.com>; Long Li <longli at microsoft.com>; Marcin Wojtas
> <mw at semihalf.com>; Martin Spinler <spinler at cesnet.cz>; Matan Azrad
> <matan at nvidia.com>; Matt Peters <matt.peters at windriver.com>; Maxime
> Coquelin <maxime.coquelin at redhat.com>; Michal Krawczyk
> <mk at semihalf.com>; Min Hu (Connor <humin29 at huawei.com>; Pradeep
> Kumar Nalla <pnalla at marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram at marvell.com>; Qiming Yang <qiming.yang at intel.com>; Qi Zhang
> <qi.z.zhang at intel.com>; Radha Chintakuntla <radhac at marvell.com>; Rahul
> Lakkireddy <rahul.lakkireddy at chelsio.com>; Rasesh Mody
> <rmody at marvell.com>; Rosen Xu <rosen.xu at intel.com>; Sachin Saxena
> <sachin.saxena at oss.nxp.com>; Satha Koteswara Rao Kottidi
> <skoteshwar at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>; Shai
> Brandes <shaibran at amazon.com>; Shepard Siegel
> <shepard.siegel at atomicrules.com>; Somalapuram Amaranath
> <asomalap at amd.com>; Somnath Kotur <somnath.kotur at broadcom.com>;
> Stephen Hemminger <sthemmin at microsoft.com>; Steven Webster
> <steven.webster at windriver.com>; Sunil Kumar Kori <skori at marvell.com>;
> Tetsuya Mukawa <mtetsuyah at gmail.com>; Veerasenareddy Burru
> <vburru at marvell.com>; Viacheslav Ovsiienko <viacheslavo at nvidia.com>; Xiao
> Wang <xiao.w.wang at intel.com>; Xiaoyun Wang
> <cloud.wangxiaoyun at huawei.com>; Yisen Zhuang
> <yisen.zhuang at huawei.com>; Yong Wang <yongwang at vmware.com>; Ziyang
> Xuan <xuanziyang2 at huawei.com>
> Subject: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, May 25, 2022 at 2:44 PM Rahul Bhansali <rbhansali at marvell.com>
> wrote:
> >
> > An additional check is added to avoid extra processing if receive
> > packets are 0.
> >
> > Performance impact: with Marvell OCTEON TX2 platform, observed an
> > improvement by ~14%.
> >
> > Signed-off-by: Rahul Bhansali <rbhansali at marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj at marvell.com>
> 
> 
> > ---
> >  examples/l2fwd/main.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index
> > 281c6b7a3f..28c498712e 100644
> > --- a/examples/l2fwd/main.c
> > +++ b/examples/l2fwd/main.c
> > @@ -286,6 +286,9 @@ l2fwd_main_loop(void)
> >                         nb_rx = rte_eth_rx_burst(portid, 0,
> >                                                  pkts_burst,
> > MAX_PKT_BURST);
> >
> > +                       if (unlikely(nb_rx == 0))
> > +                               continue;
> > +
> >                         port_statistics[portid].rx += nb_rx;
> >
> >                         for (j = 0; j < nb_rx; j++) {
> > --
> > 2.25.1
> >