[PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic

[Andrew Rybchenko]

On 6/21/22 13:33, Chaoyong He wrote:
> Add a Rx and Tx function for the control vNIC. The logic is mostly
> identical to the normal Rx and Tx functionality of the NFP PMD.
> 
> This commit also makes use of the ctrl vNIC service logic to
> service the ctrl vNIC Rx path.
> 
> Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>

[snip]

> +	/* Flower ctrl vNIC only has a single tx queue */
> +	txq = ctrl_dev->data->tx_queues[0];
> +	if (unlikely(txq == NULL)) {
> +		/*
> +		 * DPDK just checks the queue is lower than max queues
> +		 * enabled. But the queue needs to be configured
> +		 */
> +		rte_panic("ctrl dev TX Bad queue");

checkpatches.sh warnings about it [1]. Please, rework code to
avoid usage of rte_panic().


> +	}
> +
> +	txds = &txq->txds[txq->wr_p];
> +	txds->vals[0] = 0;
> +	txds->vals[1] = 0;
> +	txds->vals[2] = 0;
> +	txds->vals[3] = 0;
> +
> +	if (nfp_net_nfd3_txq_full(txq))
> +		nfp_net_tx_free_bufs(txq);
> +
> +	free_descs = nfp_net_nfd3_free_tx_desc(txq);
> +	if (unlikely(free_descs == 0))
> +		rte_panic("ctrl dev no free descs");

same here

[snip]

[1] http://mails.dpdk.org/archives/test-report/2022-June/290999.html