[PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()
Thomas Monjalon
thomas at monjalon.net
Sun Jun 26 23:16:14 CEST 2022
27/05/2022 08:42, Usman Tanveer:
> There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()
> due to which user gets misleading message upon first open/start call.
> It says that the
> device is already stopped, which should not be the case. This patch
> removes rte_eth_dev_stop() from rte_ethtool_net_open().
Why was it there?
Any opinion? Is it safe to remove?
> int
> rte_ethtool_net_open(uint16_t port_id)
> {
> - int ret;
> -
> - ret = rte_eth_dev_stop(port_id);
> - if (ret != 0)
> - return ret;
> -
> return rte_eth_dev_start(port_id);
> }
More information about the dev
mailing list