[PATCH v3] net/igc: move the initialization of data path into dev_init

[Zhang, Qi Z]

> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng at intel.com>
> Sent: Tuesday, June 28, 2022 2:21 PM
> To: dev at dpdk.org
> Cc: stable at dpdk.org; Yang, Qiming <qiming.yang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Zeng, ZhichaoX <zhichaox.zeng at intel.com>;
> alvinx.zhang at intel.com; Guo, Junfeng <junfeng.guo at intel.com>; Su, Simei
> <simei.su at intel.com>; Ferruh Yigit <ferruh.yigit at intel.com>
> Subject: [PATCH v3] net/igc: move the initialization of data path into dev_init
> 
> From: Zhichao Zeng <zhichaox.zeng at intel.com>
> 
> The upper-layer application usually call the common interface "dev_init"
> to initialize the data path, but in the igc driver, the initialization of data path is in
> "igc_rx_init" and "eth_igc_tx_queue_setup", while in other drivers it is in
> "dev_init". So when upper-layer application calling these function pointers will
> occur segmentation faults.

NO, for most intel PMD e.g.: i40e and ice, we don't initialize data path in dev_init.

> 
> This patch moves the initialization of data path into "eth_igc_dev_init"
> to avoid segmentation faults, which is consistent with other drivers.

I saw dev->rx_pkt_burst can be overwritten in igc_rx_init, I assume the issue still be exist.