[PATCH] net/vhost: fix compliant offloading flag

Maxime Coquelin maxime.coquelin at redhat.com
Tue Jun 28 11:57:02 CEST 2022



On 6/28/22 11:42, xuan.ding at intel.com wrote:
> From: Xuan Ding <xuan.ding at intel.com>
> 
> This patch fixes the check to set compliant offloading flag.
> Compliant offloading flag should be set when the
> 'legacy-ol-flags' is true.
> 
> Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode")
> 
> Signed-off-by: Xuan Ding <xuan.ding at intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index d75d256040..24049df58a 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1735,7 +1735,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
>   			goto out_free;
>   	}
>   
> -	if (legacy_ol_flags == 0)
> +	if (legacy_ol_flags == 1)
>   		flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
>   
>   	if (dev->device.numa_node == SOCKET_ID_ANY)

Nack, legacy OL flags is NOT compliant. So current implementation is
good.

Regards,
Maxime



More information about the dev mailing list