[PATCH 1/2] common/cnxk: revert check on bitmap for tm

Nithin Dabilpuram ndabilpuram at marvell.com
Thu Mar 3 08:00:41 CET 2022


Revert change to return error on case where no slab of free
resources is found. That error check break's a case where
there is a spare schq to be reused that was just allocated
for sake of contiguous static TM nodes.

Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values")
Cc: gmuthukrishn at marvell.com

Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>
---
 drivers/common/cnxk/roc_nix_tm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c
index 7a17780..5b70c7b 100644
--- a/drivers/common/cnxk/roc_nix_tm.c
+++ b/drivers/common/cnxk/roc_nix_tm.c
@@ -1042,10 +1042,8 @@ nix_tm_assign_hw_id(struct nix *nix, struct nix_tm_node *parent,
 			return -EFAULT;
 		}
 
-		if (!slab) {
-			if (!plt_bitmap_scan(bmp, &pos, &slab))
-				return -ENOENT;
-		}
+		if (!slab)
+			plt_bitmap_scan(bmp, &pos, &slab);
 
 		if (child->priority == parent->rr_prio && spare_schq != -1) {
 			/* Use spare schq first if present */
-- 
2.8.4



More information about the dev mailing list