[PATCH] vhost: use colon in version.map

Xia, Chenbo chenbo.xia at intel.com
Thu Mar 3 12:32:04 CET 2022


> -----Original Message-----
> From: Peng Yu <penyu at amazon.com>
> Sent: Tuesday, February 15, 2022 1:56 PM
> To: dev at dpdk.org
> Cc: Peng Yu <penyu at amazon.com>; Ray Kinsella <mdr at ashroe.eu>; Maxime Coquelin
> <maxime.coquelin at redhat.com>; Xia, Chenbo <chenbo.xia at intel.com>
> Subject: [PATCH] vhost: use colon in version.map
> 
> The punctuation after the `global` keyword should be colon, not
> semicolon. The default gcc linker accepts both colon and semicolon, but
> the gold linker will report syntax error if we use semicolon after the
> `global` keyword.
> 
> Signed-off-by: Peng Yu <penyu at amazon.com>
> ---
>  lib/vhost/version.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 1202ba9c1a..0a66c5840c 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -90,7 +90,7 @@ EXPERIMENTAL {
>  };
> 
>  INTERNAL {
> -	global;
> +	global:
> 
>  	rte_vdpa_register_device;
>  	rte_vdpa_relay_vring_used;
> --
> 2.16.6

Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>


More information about the dev mailing list