[PATCH v2] common/mlx5: fix missing default devargs initialization

[Ferruh Yigit]

On 3/2/2022 4:33 PM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Michael Baum <michaelba at nvidia.com>
>> Sent: Tuesday, March 1, 2022 1:10 PM
>> To: dev at dpdk.org
>> Cc: Matan Azrad <matan at nvidia.com>; Raslan Darawsheh
>> <rasland at nvidia.com>; Slava Ovsiienko <viacheslavo at nvidia.com>
>> Subject: [PATCH v2] common/mlx5: fix missing default devargs initialization
>>
>> Device arguments list is provided along with its identifier as part of EAL
>> arguments.
>> The arguments specified in the list are taken from it, and the rest is initialized
>> to the default values.
>>
>> When no list is provided at all, all arguments should have been initialized to
>> their default values. However, they are mistakenly initialized to zero which
>> may be a valid value for some.
>>
>> This patch initializes the default values before checking whether arguments
>> have been specified.
>>
>> Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management")
> added:
> Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=945

We have a defined keyword for it, and it should go before Fixes tag, like:

      Bugzilla ID: 945
      Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management")

updated accordingly in next-net

>>
>> Signed-off-by: Michael Baum <michaelba at nvidia.com>
>> Acked-by: Matan Azrad <matan at nvidia.com>
>> ---
>>
>> v2: updating Fixes reference hash.
>>
>>   drivers/common/mlx5/mlx5_common.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
> 
> Patch applied to next-net-mlx,
> 
> Kindest regards,
> Raslan Darawsheh