[PATCH v1] net/i40e: remove redundant number of packets check
Ferruh Yigit
ferruh.yigit at intel.com
Thu Mar 3 17:43:33 CET 2022
On 3/3/2022 2:28 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Feifei Wang <feifei.wang2 at arm.com>
>> Sent: Thursday, March 3, 2022 9:54 AM
>> To: Xing, Beilei <beilei.xing at intel.com>; David Christensen
>> <drc at linux.vnet.ibm.com>; Richardson, Bruce <bruce.richardson at intel.com>;
>> Ananyev, Konstantin <konstantin.ananyev at intel.com>; Ruifeng Wang
>> <ruifeng.wang at arm.com>
>> Cc: dev at dpdk.org; nd at arm.com; Feifei Wang <feifei.wang2 at arm.com>;
>> Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
>> Subject: [PATCH v1] net/i40e: remove redundant number of packets check
>>
>> For i40e_xmit_pkts_vec_xx function, it checks nb_pkts to ensure nb_pkts does
>> not cross rs_thresh.
>>
>> However, in i40e_xmit_fixed_burst_vec_xx function, this check will be
>> performed again. To improve code, delete this redundant check.
>>
>> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
>> Signed-off-by: Feifei Wang <feifei.wang2 at arm.com>
>> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
>
> Applied to dpdk-next-net-intel.
>
Hi Qi,
This patch is not acked by the i40e maintainers.
And this is changing the datapath for the -rc3, two weeks before
the release. Is it tested enough?
What is the gain with this patch, I don't see any numbers
in the commit log.
If the gain is small, can we postpone this patch to next
release instead of getting it for -rc3?
More information about the dev
mailing list