[PATCH] devtools: fix symbols check
Thomas Monjalon
thomas at monjalon.net
Tue Mar 8 22:18:59 CET 2022
In some environments, the check of local symbols catch-all
was failing. Note: this script is called during the build.
The reason is that grep returns an error if nothing is found.
The option -e of the shell script makes this error fatal.
It is not always fatal because the grep is in a command substitution.
Fixes: b403498e1422 ("build: hide local symbols in shared libraries")
Reported-by: Usama Arif <usama.arif at bytedance.com>
Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
---
devtools/check-symbol-maps.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
index 8266fdf9ea..32e1fa5c8f 100755
--- a/devtools/check-symbol-maps.sh
+++ b/devtools/check-symbol-maps.sh
@@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then
ret=1
fi
-local_miss_maps=$(grep -L 'local: \*;' $@)
+local_miss_maps=$(grep -L 'local: \*;' $@ || true)
if [ -n "$local_miss_maps" ] ; then
echo "Found maps without local catch-all:"
echo "$local_miss_maps"
--
2.34.1
More information about the dev
mailing list