[PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally"
Thomas Monjalon
thomas at monjalon.net
Tue Mar 15 12:22:59 CET 2022
14/03/2022 13:27, Megha Ajmera:
> This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e.
>
> When enabling TC OV unconditionally, it is observed the performance
> drops by ~20% hence reverting this commit.
>
> Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription
> unconditionally")
>
> Signed-off-by: Megha Ajmera <megha.ajmera at intel.com>
Repeating what was suggested yesterday in a private email.
Sorry Megha, I don't know why you were not Cc'ed by your Intel colleagues.
David and I suggested to drop the code which was enabled
by the compilation flag RTE_SCHED_SUBPORT_TC_OV,
which was kind of dead code before enabling it unconditionally.
This way you maintain the performance of the default compilation,
and you can re-introduce the feature, if proven useful,
in the next release with a runtime option.
More information about the dev
mailing list