[PATCH] eal: factorize lcore main loop
David Marchand
david.marchand at redhat.com
Fri Mar 25 16:09:50 CET 2022
On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon <thomas at monjalon.net> wrote:
> > > But seeing how this code has been there from day 1, I would not
> > > request a backport.
> >
> > this looks better to me it ends up being a bit less code and it solves
> > the problem in a general fashion for platforms including windows.
> >
> > on windows the implementation does run the start_routine before assigning
> > thread which was addressed with this patch. (still not merged)
> > http://patchwork.dpdk.org/project/dpdk/list/?series=22094
> >
> > it's likely your patch will be merged before mine so when that happens
> > i'll just quietly abandon mine. however if some desire exists for a
> > backport the simpler patch i provided could be used.
>
> Your patch could be merged now that we start a new cycle.
> What do you prefer? Is David's solution better?
> In this case, should we reject your patch?
We can merge Tyler fix right away because it is a real issue on
Windows and it can be backported.
My series can be rebased and merged later as a cleanup/unified
solution for all OS.
--
David Marchand
More information about the dev
mailing list