[PATCH 1/6] eventdev: support to set queue attributes at runtime

[Van Haaren, Harry]

> -----Original Message-----
> From: Shijith Thotton <sthotton at marvell.com>
> Sent: Tuesday, March 29, 2022 2:11 PM
> To: dev at dpdk.org; jerinj at marvell.com
> Cc: Shijith Thotton <sthotton at marvell.com>; pbhagavatula at marvell.com; Ray
> Kinsella <mdr at ashroe.eu>
> Subject: [PATCH 1/6] eventdev: support to set queue attributes at runtime

<snip>

> +/**
> + * Set an event queue attribute at runtime.
> + *
> + * @param dev
> + *   Event device pointer
> + * @param queue_id
> + *   Event queue index
> + * @param attr_id
> + *   Event queue attribute id
> + * @param attr_value
> + *   Event queue attribute value
> + *
> + * @return
> + *  - 0: Success.
> + *  - <0: Error code on failure.
> + */
> +typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev,
> +					 uint8_t queue_id, uint32_t attr_id,
> +					 uint32_t attr_value);

Is using a uint64_t a better type for attr_value? Given there might be more in future,
limiting to 32-bits now may cause headaches later, and uint64_t doesn't cost extra?

I think 32-bits of attr_id is enough :)

Same comment on the _get() API in patch 2/6, a uint64_t * would be a better fit there in my opinion.

<snip>