[PATCH] app/testpmd: perform SW IP checksum for GRO packets

[Ma, WenwuX]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: 2022年5月11日 15:28
> To: Ma, WenwuX <wenwux.ma at intel.com>
> Cc: Li, Xiaoyun <xiaoyun.li at intel.com>; Singh, Aman Deep
> <aman.deep.singh at intel.com>; Zhang, Yuying <yuying.zhang at intel.com>;
> dev <dev at dpdk.org>; Hu, Jiayu <jiayu.hu at intel.com>; Wang, Yinan
> <yinan.wang at intel.com>; He, Xingguang <xingguang.he at intel.com>
> Subject: Re: [PATCH] app/testpmd: perform SW IP checksum for GRO
> packets
> 
> On Wed, May 11, 2022 at 3:40 AM Wenwu Ma <wenwux.ma at intel.com>
> wrote:
> >
> > The GRO library doesn't re-calculate checksums for merged packets. If
> > users want the merged packets to have correct IP checksums, they
> > should select HW IP checksum calculation for the port which the merged
> > packets are transmitted to. But if the port doesn't support HW IP
> > checksum, users may perform a SW IP checksum. This patch add the code
> > about it.
> 
> It looks like a fix, please add a Fixes: line.
ok

> Out of curiosity, would there be an issue too when using the gso library?
> 
yes, gso library has the same issue. IP checksum need  to be re-calculated for fragmented packets

> >
> > Signed-off-by: Wenwu Ma <wenwux.ma at intel.com>
> 
> 
> --
> David Marchand