[RFC PATCH 2/4] net/bonding: move testpmd commands

Konstantin Ananyev konstantin.v.ananyev at yandex.ru
Thu May 19 01:25:20 CEST 2022


18/05/2022 18:24, David Marchand пишет:
> On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) <humin29 at huawei.com> wrote:
>>
>>    I think net/bonding offer 'API' for APP to use the bonding.
>>      and use the specific PMD as slave device.
>>    The software framwork is like:
>>     APP
>>     ethdev
>>     bonding PMD
>>     PMD
>>     hardware
>>
>> so, I think cmdlines for testpmd should not put in net/bonding.be

Actually, I feel the same.
I do understand the intention, and I do realize it is just location,
but still doesn't look right for me.
can't we have a special sub-folder in testpmd instead?
Something like app/testpmd/driver_specific/(ixgbe)|(i40e)|(bonding)...


> 
> Sorry, but the distinction is vague.
> 
> Those commands are specific to this driver/library.
> I don't see the problem with hosting the commands in the bonding driver/library.
> 
> This is still a RFC, I don't mind dropping this patch (in the end) if
> others think it does not make sense.
> For now I'll keep it in a v2 series fixing the registering issue in patch 1.
> 
> 



More information about the dev mailing list