[EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input

Gowrishankar Muthukrishnan gmuthukrishn at marvell.com
Thu May 19 07:30:09 CEST 2022


Please find comments inline from CI point of view.

> -----Original Message-----
....
....
>  main(int argc, char *argv[])
>  {
>  	int ret;
> +	char use_json;
> 
>  	ret = rte_eal_init(argc, argv);
>  	if (ret < 0) {
> @@ -424,9 +436,17 @@ main(int argc, char *argv[])
>  					ret, env.req_path);
>  			goto exit;
>  		}
> -
> -
> +		use_json = info.file_type == FIPS_TYPE_JSON;

use_json is not required apart from setting info.file_type. Some CI build fails
for unused use_json (when !RTE_HAS_JANSSON). Can this be removed ?.

Thanks,
Gowrishankar



More information about the dev mailing list