[RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

Thomas Monjalon thomas at monjalon.net
Mon May 23 12:58:50 CEST 2022


23/05/2022 08:07, Morten Brørup:
> > +	uint8_t lwm;
> 
> Why percentage, why not 1/128th, or 1/16th? 2^N seems more logical, and I wonder if such high granularity is really necessary. Just a thought, it's not important.

I think percentage is the easiest to understand
and to share with other teams in design documents.

> If you stick with percentage, it only needs 7 bits, and you can make the remaining one bit reserved.
> 
> Also, please add here that 0 means disable.

Good idea.




More information about the dev mailing list