[PATCH 1/6] app/testpmd: mark most cmdline symbols as static

Ferruh Yigit ferruh.yigit at amd.com
Mon May 23 20:09:27 CEST 2022


On 5/23/2022 11:19 AM, Dumitrescu, Cristian wrote:
> [CAUTION: External Email]
> 
>> -----Original Message-----
>> From: David Marchand <david.marchand at redhat.com>
>> Sent: Monday, May 23, 2022 8:10 AM
>> To: dev at dpdk.org
>> Cc: thomas at monjalon.net; andrew.rybchenko at oktetlabs.ru;
>> ferruh.yigit at xilinx.com; Konstantin Ananyev
>> <konstantin.v.ananyev at yandex.ru>; Li, Xiaoyun <xiaoyun.li at intel.com>; Singh,
>> Aman Deep <aman.deep.singh at intel.com>; Zhang, Yuying
>> <yuying.zhang at intel.com>; Ori Kam <orika at nvidia.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu at intel.com>
>> Subject: [PATCH 1/6] app/testpmd: mark most cmdline symbols as static
>>
>> All those symbols don't need to be global, plus it was hiding unused
>> code such as:
>> - cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack in
>>    cmdline.c,
>> - cmd_create_port_meter_g_action, cmd_create_port_meter_r_action,
>>    cmd_create_port_meter_y_action in cmdline_mtr.c,
>>
>> Mark those symbols as static.
>>
>> Signed-off-by: David Marchand <david.marchand at redhat.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit at xilinx.com>


More information about the dev mailing list