[PATCH v8 5/5] ethdev: format module EEPROM for SFF-8636

[Andrew Rybchenko]

On 5/25/22 06:14, Robin Zhang wrote:
> This patch implements format module EEPROM information for
> SFF-8636 Rev 2.7
> 
> Signed-off-by: Robin Zhang <robinx.zhang at intel.com>

[snip]

> diff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c
> new file mode 100644
> index 0000000000..ad625fc73b
> --- /dev/null
> +++ b/lib/ethdev/sff_8636.c
> @@ -0,0 +1,750 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + *
> + * Implements SFF-8636 based QSFP+/QSFP28 Diagnostics Memory map.
> + *
> + */
> +
> +#include <stdio.h>
> +#include <math.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_flow.h>
> +#include "sff_common.h"
> +#include "sff_8636.h"
> +#include "ethdev_sff_telemetry.h"

Please, fix includes

> +/* Flat Memory:0- Paging, 1- Page 0 only */
> +#define	SFF_8636_STATUS_PAGE_3_PRESENT		(1 << 2)

RTE_BIT32 here and in many cases below?