[PATCH] drivers: suggestion on removing empty version.map files

[Omer Yamac]

On 03.10.2022 12:19, Bruce Richardson wrote:
> On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote:
>> In this patch, we remove all version.map files which include
>> only the below part:
>> `DPDK_23 {
>> 	local: *;
>> };`
>> 
>> Then we modify the meson.build to be able to compile without 
>> version.map
>> 
>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac at ceng.metu.edu.tr>
>> Suggested-by: Ferruh Yigit <ferruh.yigit at amd.com>
>> ---
> 
> I think you need to flag this as depending on us bumping the meson 
> version
> requirement up to 0.53 as has been proposed. This doesn't work with 
> 0.4x
> versions.
> 
Thanks for your warnings.
Instead of using fs module, I will use python script that checks file 
exist or not.
If it is okay, I will resubmit the patch.
> One other suggestion is to split this into 2 patches. Have the first 
> patch
> just with the meson changes to support this, and the second patch then
> doing the actual removal. That would make this a lot easier to review 
> since
> the code needing the review will all be in the first patch.
> 
I will do in the next patch.
> Otherwise, good idea!
> 
> Regards,
> /Bruce

Thanks