[EXT] Re: [PATCH v2 0/4] add trace points in ethdev library

[Ankur Dwivedi]

Hi Andrew,

>-----Original Message-----
>From: Ankur Dwivedi
>Sent: Thursday, October 6, 2022 1:18 PM
>To: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>; dev at dpdk.org
>Cc: thomas at monjalon.net; mdr at ashroe.eu; orika at nvidia.com;
>ferruh.yigit at xilinx.com; chas3 at att.com; humin29 at huawei.com;
>linville at tuxdriver.com; ciara.loftus at intel.com; qi.z.zhang at intel.com;
>mw at semihalf.com; mk at semihalf.com; shaibran at amazon.com;
>evgenys at amazon.com; igorch at amazon.com; chandu at amd.com; Igor
>Russkikh <irusskikh at marvell.com>; shepard.siegel at atomicrules.com;
>ed.czeck at atomicrules.com; john.miller at atomicrules.com;
>ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com; Jerin Jacob
>Kollanukkaran <jerinj at marvell.com>; Maciej Czekaj [C]
><mczekaj at marvell.com>; Shijith Thotton <sthotton at marvell.com>;
>Srisivasubramanian Srinivasan <srinivasan at marvell.com>; Harman Kalra
><hkalra at marvell.com>; rahul.lakkireddy at chelsio.com; johndale at cisco.com;
>hyonkim at cisco.com; liudongdong3 at huawei.com;
>yisen.zhuang at huawei.com; xuanziyang2 at huawei.com;
>cloud.wangxiaoyun at huawei.com; zhouguoyang at huawei.com;
>simei.su at intel.com; wenjun1.wu at intel.com; qiming.yang at intel.com;
>Yuying.Zhang at intel.com; beilei.xing at intel.com; xiao.w.wang at intel.com;
>jingjing.wu at intel.com; junfeng.guo at intel.com; rosen.xu at intel.com; Nithin
>Kumar Dabilpuram <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda
><kirankumark at marvell.com>; Sunil Kumar Kori <skori at marvell.com>; Satha
>Koteswara Rao Kottidi <skoteshwar at marvell.com>; Liron Himi
><lironh at marvell.com>; zr at semihalf.com; Radha Chintakuntla
><radhac at marvell.com>; Veerasenareddy Burru <vburru at marvell.com>;
>Sathesh B Edara <sedara at marvell.com>; matan at nvidia.com;
>viacheslavo at nvidia.com; sthemmin at microsoft.com; longli at microsoft.com;
>spinler at cesnet.cz; chaoyong.he at corigine.com;
>niklas.soderlund at corigine.com; hemant.agrawal at nxp.com;
>sachin.saxena at oss.nxp.com; g.singh at nxp.com; apeksha.gupta at nxp.com;
>sachin.saxena at nxp.com; aboyer at pensando.io; Rasesh Mody
><rmody at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>; Devendra
>Singh Rawat <dsinghrawat at marvell.com>; jiawenwu at trustnetic.com;
>jianwang at trustnetic.com; jbehrens at vmware.com;
>maxime.coquelin at redhat.com; chenbo.xia at intel.com;
>steven.webster at windriver.com; matt.peters at windriver.com;
>bruce.richardson at intel.com; mtetsuyah at gmail.com; grive at u256.net;
>jasvinder.singh at intel.com; cristian.dumitrescu at intel.com;
>jgrajcia at cisco.com
>Subject: RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library
>
>
>
>>-----Original Message-----
>>From: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
>>Sent: Thursday, October 6, 2022 12:59 PM
>>To: Ankur Dwivedi <adwivedi at marvell.com>; dev at dpdk.org
>>Cc: thomas at monjalon.net; mdr at ashroe.eu; orika at nvidia.com;
>>ferruh.yigit at xilinx.com; chas3 at att.com; humin29 at huawei.com;
>>linville at tuxdriver.com; ciara.loftus at intel.com; qi.z.zhang at intel.com;
>>mw at semihalf.com; mk at semihalf.com; shaibran at amazon.com;
>>evgenys at amazon.com; igorch at amazon.com; chandu at amd.com; Igor
>Russkikh
>><irusskikh at marvell.com>; shepard.siegel at atomicrules.com;
>>ed.czeck at atomicrules.com; john.miller at atomicrules.com;
>>ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com; Jerin Jacob
>>Kollanukkaran <jerinj at marvell.com>; Maciej Czekaj [C]
>><mczekaj at marvell.com>; Shijith Thotton <sthotton at marvell.com>;
>>Srisivasubramanian Srinivasan <srinivasan at marvell.com>; Harman Kalra
>><hkalra at marvell.com>; rahul.lakkireddy at chelsio.com;
>johndale at cisco.com;
>>hyonkim at cisco.com; liudongdong3 at huawei.com;
>yisen.zhuang at huawei.com;
>>xuanziyang2 at huawei.com; cloud.wangxiaoyun at huawei.com;
>>zhouguoyang at huawei.com; simei.su at intel.com; wenjun1.wu at intel.com;
>>qiming.yang at intel.com; Yuying.Zhang at intel.com; beilei.xing at intel.com;
>>xiao.w.wang at intel.com; jingjing.wu at intel.com; junfeng.guo at intel.com;
>>rosen.xu at intel.com; Nithin Kumar Dabilpuram
><ndabilpuram at marvell.com>;
>>Kiran Kumar Kokkilagadda <kirankumark at marvell.com>; Sunil Kumar Kori
>><skori at marvell.com>; Satha Koteswara Rao Kottidi
>><skoteshwar at marvell.com>; Liron Himi <lironh at marvell.com>;
>>zr at semihalf.com; Radha Chintakuntla <radhac at marvell.com>;
>>Veerasenareddy Burru <vburru at marvell.com>; Sathesh B Edara
>><sedara at marvell.com>; matan at nvidia.com; viacheslavo at nvidia.com;
>>sthemmin at microsoft.com; longli at microsoft.com; spinler at cesnet.cz;
>>chaoyong.he at corigine.com; niklas.soderlund at corigine.com;
>>hemant.agrawal at nxp.com; sachin.saxena at oss.nxp.com; g.singh at nxp.com;
>>apeksha.gupta at nxp.com; sachin.saxena at nxp.com; aboyer at pensando.io;
>>Rasesh Mody <rmody at marvell.com>; Shahed Shaikh
><shshaikh at marvell.com>;
>>Devendra Singh Rawat <dsinghrawat at marvell.com>;
>>jiawenwu at trustnetic.com; jianwang at trustnetic.com;
>jbehrens at vmware.com;
>>maxime.coquelin at redhat.com; chenbo.xia at intel.com;
>>steven.webster at windriver.com; matt.peters at windriver.com;
>>bruce.richardson at intel.com; mtetsuyah at gmail.com; grive at u256.net;
>>jasvinder.singh at intel.com; cristian.dumitrescu at intel.com;
>>jgrajcia at cisco.com
>>Subject: Re: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev
>>library
>>
>>On 10/6/22 10:26, Ankur Dwivedi wrote:
>>> Hi Andrew,
>>>
>>>> -----Original Message-----
>>>> From: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
>>>> Sent: Thursday, October 6, 2022 12:40 PM
>>>> To: Ankur Dwivedi <adwivedi at marvell.com>; dev at dpdk.org
>>>> Cc: thomas at monjalon.net; mdr at ashroe.eu; orika at nvidia.com;
>>>> ferruh.yigit at xilinx.com; chas3 at att.com; humin29 at huawei.com;
>>>> linville at tuxdriver.com; ciara.loftus at intel.com;
>>>> qi.z.zhang at intel.com; mw at semihalf.com; mk at semihalf.com;
>>>> shaibran at amazon.com; evgenys at amazon.com; igorch at amazon.com;
>>>> chandu at amd.com; Igor
>>Russkikh
>>>> <irusskikh at marvell.com>; shepard.siegel at atomicrules.com;
>>>> ed.czeck at atomicrules.com; john.miller at atomicrules.com;
>>>> ajit.khaparde at broadcom.com; somnath.kotur at broadcom.com; Jerin
>>Jacob
>>>> Kollanukkaran <jerinj at marvell.com>; Maciej Czekaj [C]
>>>> <mczekaj at marvell.com>; Shijith Thotton <sthotton at marvell.com>;
>>>> Srisivasubramanian Srinivasan <srinivasan at marvell.com>; Harman Kalra
>>>> <hkalra at marvell.com>; rahul.lakkireddy at chelsio.com;
>>>> johndale at cisco.com; hyonkim at cisco.com; liudongdong3 at huawei.com;
>>>> yisen.zhuang at huawei.com; xuanziyang2 at huawei.com;
>>>> cloud.wangxiaoyun at huawei.com; zhouguoyang at huawei.com;
>>>> simei.su at intel.com; wenjun1.wu at intel.com; qiming.yang at intel.com;
>>>> Yuying.Zhang at intel.com; beilei.xing at intel.com;
>>>> xiao.w.wang at intel.com; jingjing.wu at intel.com; junfeng.guo at intel.com;
>>>> rosen.xu at intel.com; Nithin Kumar Dabilpuram
>>>> <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda
>>>> <kirankumark at marvell.com>; Sunil Kumar Kori <skori at marvell.com>;
>>>> Satha Koteswara Rao Kottidi <skoteshwar at marvell.com>; Liron Himi
>>>> <lironh at marvell.com>; zr at semihalf.com; Radha Chintakuntla
>>>> <radhac at marvell.com>; Veerasenareddy Burru <vburru at marvell.com>;
>>>> Sathesh B Edara <sedara at marvell.com>; matan at nvidia.com;
>>>> viacheslavo at nvidia.com; sthemmin at microsoft.com;
>>>> longli at microsoft.com; spinler at cesnet.cz; chaoyong.he at corigine.com;
>>>> niklas.soderlund at corigine.com; hemant.agrawal at nxp.com;
>>>> sachin.saxena at oss.nxp.com;
>>g.singh at nxp.com;
>>>> apeksha.gupta at nxp.com; sachin.saxena at nxp.com;
>aboyer at pensando.io;
>>>> Rasesh Mody <rmody at marvell.com>; Shahed Shaikh
>>>> <shshaikh at marvell.com>; Devendra Singh Rawat
>>>> <dsinghrawat at marvell.com>; jiawenwu at trustnetic.com;
>>>> jianwang at trustnetic.com; jbehrens at vmware.com;
>>>> maxime.coquelin at redhat.com; chenbo.xia at intel.com;
>>>> steven.webster at windriver.com; matt.peters at windriver.com;
>>>> bruce.richardson at intel.com; mtetsuyah at gmail.com; grive at u256.net;
>>>> jasvinder.singh at intel.com; cristian.dumitrescu at intel.com;
>>>> jgrajcia at cisco.com
>>>> Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library
>>>>
>>>> External Email
>>>>
>>>> --------------------------------------------------------------------
>>>> -
>>>> - On 9/29/22 13:29, Ankur Dwivedi wrote:
>>>>> This series adds trace points for functions in the ethdev library.
>>>>> The trace points are added in ethdev, flow, mtr and tm files.
>>>>>
>>>>> v2:
>>>>>    - Made rte_eth_trace_call_rx_callbacks and
>>rte_eth_trace_call_tx_callbacks
>>>>>      as fastpath trace functions.
>>>>>    - Moved some trace functions call to the end to capture return value
>and
>>>>>      data.
>>>>
>>>> Looking at the patch series I still see many-many places where
>>>> tracing happens on entry point. Intentional?
>>> Yes , because the return values are not there to be captured.
>>
>>Isn't it the reason to move trace point to have return value there and
>>capture it?
>[Ankur] For some function the return value was there to be captured. But for
>some functions the return values are not possible to get unless some more
>changes are made in code, like the rte_eth_rx_metadata_negotiate() you
>mentioned in earlier mail. I have not modified the existing code of library, just
>added trace to capture what can be captured.
[Ankur] Identified few more functions for which trace can be shift towards the end of a function. Will send the changes in v3.
>>
>>>>
>>>>>    - Removed rte_eth_trace_tx_queue_setup as it is not required.
>>>>>      rte_ethdev_trace_txq_setup() is already present in
>>>>>      rte_eth_tx_queue_setup().
>>>>>    - Removed trace in ethdev_driver.c
>>>>>    - Removed trace function check patch.
>>>>>
>>>>> Ankur Dwivedi (4):
>>>>>     ethdev: add trace points
>>>>>     ethdev: add trace points for flow
>>>>>     ethdev: add trace points for mtr
>>>>>     ethdev: add trace points for tm
>>>>>
>>>>>    lib/ethdev/ethdev_private.c      |    3 +
>>>>>    lib/ethdev/ethdev_trace_points.c |  699 ++++++++++
>>>>>    lib/ethdev/rte_ethdev.c          |  148 +++
>>>>>    lib/ethdev/rte_ethdev_trace.h    | 2062
>>>> ++++++++++++++++++++++++++++++
>>>>>    lib/ethdev/rte_ethdev_trace_fp.h |   19 +
>>>>>    lib/ethdev/rte_flow.c            |   54 +
>>>>>    lib/ethdev/rte_mtr.c             |   27 +
>>>>>    lib/ethdev/rte_tm.c              |   40 +
>>>>>    lib/ethdev/version.map           |  232 ++++
>>>>>    9 files changed, 3284 insertions(+)
>>>>>
>>>