[PATCH v4 2/9] net/gve/base: add logs and OS specific implementation

[Ferruh Yigit]

On 9/27/2022 8:32 AM, Junfeng Guo wrote:

> 
> Add GVE PMD logs.
> Add some MACRO definitions and memory operations which are specific
> for DPDK.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang at intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo at intel.com>

<...>

> --- /dev/null
> +++ b/drivers/net/gve/gve_logs.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2022 Intel Corporation
> + */
> +
> +#ifndef _GVE_LOGS_H_
> +#define _GVE_LOGS_H_
> +
> +extern int gve_logtype_driver;
> +
> +#define PMD_DRV_LOG(level, fmt, args...) \
> +       rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", \
> +               __func__, ## args)
> +

What do you think to move 'gve_logs.h' to next patch, since this is 
extern 'gve_logtype_driver' which is not added yet.
Although files are not compiled yet, logically I think it suits better 
to next patch.