[PATCH v5 1/3] ethdev: support mulitiple mbuf pools per Rx queue

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Fri Oct 7 16:13:41 CEST 2022


On 10/6/22 20:29, Stephen Hemminger wrote:
> On Thu, 6 Oct 2022 22:31:24 +0530
> Hanumanth Pothula <hpothula at marvell.com> wrote:
> 
>> +	/**
>> +	 * Points to an array of mempools.
>> +	 *
>> +	 * Valid only when RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL flag is set in
>> +	 * Rx offloads.
>> +	 *
>> +	 * This provides support for  multiple mbuf pools per Rx queue.
>> +	 *
>> +	 * This is often useful for saving the memory where the application can
>> +	 * create a different pools to steer the specific size of the packet, thus
>> +	 * enabling effective use of memory.
>> +	 *
>> +	 * Note that on Rx scatter enable, a packet may be delivered using a chain
>> +	 * of mbufs obtained from single mempool or multiple mempools based on
>> +	 * the NIC implementation.
>> +	 */
>> +	struct rte_mempool **rx_mempools;
>> +	uint16_t rx_npool; /** < number of mempools */
>> +
>>   	uint64_t reserved_64s[2]; /**< Reserved for future fields */
>>   	void *reserved_ptrs[2];   /**< Reserved for future fields */
> 
> Better and safer to just take up some of those existing reserved fields.
> 

I don't understand why. We're braking ABI anyway.


More information about the dev mailing list