[PATCH v8 2/4] ethdev: support multiple mbuf pools per Rx queue

[Andrew Rybchenko]

On 10/7/22 21:35, Thomas Monjalon wrote:
> 07/10/2022 19:29, Andrew Rybchenko:
>> +* **Added support for mulitiple mbuf pools per ethdev Rx queue.**
> 
> mulitiple -> multiple
> 
> I can fix when merging.

Thanks, I've delegated first 3 patches to you. I think it is ready to
go. Let's sort out testpmd patch a bit later. May be we'll have
testpmd maintainers review.

> 
>> +
>> +  The capability allows application to provide many mempools of different
>> +  size and PMD and/or NIC to choose a memory pool based on the packet's
>> +  length and/or Rx buffers availability.
> [...]
>> +	/**
>> +	 * Array of mempools to allocate Rx buffers from.
>> +	 *
>> +	 * This provides support for multiple mbuf pools per Rx queue.
>> +	 * The capability is reported in device info via positive
>> +	 * max_rx_mempools.
>> +	 *
>> +	 * It could be useful for more efficient usage of memory when an
>> +	 * application creates different mempools to steer the specific
>> +	 * size of the packet.
>> +	 *
>> +	 * If many mempools are specified, packets received using Rx
>> +	 * burst may belong to any provided mempool. From ethdev user point
>> +	 * of view it is undefined how PMD/NIC chooses mempool for a packet.
>> +	 *
>> +	 * If Rx scatter is enabled, a packet may be delivered using a chain
>> +	 * of mbufs obtained from single mempool or multiple mempools based
>> +	 * on the NIC implementation.
>> +	 */
>> +	struct rte_mempool **rx_mempools;
>> +	uint16_t rx_nmempool; /** < Number of Rx mempools */
> 
> OK, it's clear, thanks.
> 
>