[PATCH 1/2] drivers: suggestion on meson without version file

[Bruce Richardson]

On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote:
> 
<snip>
> > Beware that the shared_lib calls use both lk_deps and lk_args
> > parameters,
> > which are only set inside the "if" block you added.
> > This will cause problems in that:
> > 1. If the first driver doesn't have a version.map file, these variables
> >    will be undefined and you'll get a build error.
> > 2. For any subsequent drivers that don't have a version.map file, the
> > old
> >    values of the variables from the previous driver will be used.
> > 
> You're right, I missed that part and I will add a "else condition" to set
> variables as empty. Then everything is OK?

Don't add an "else" leg as it will complicate things. Instead, initialize
them to empty at the start of the per-driver block, where we initialize
the other variables. It doesn't matter having them assigned twice in the
one block.

Thanks,
/Bruce