[PATCH v2 05/24] net/nfp: add the offload support of basic actions

[Ferruh Yigit]

On 10/10/2022 7:08 AM, Chaoyong He wrote:
> Add the offload support of very basic actions: mark, rss,
> count, drop and output.
> 
> Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
> ---
>   doc/guides/nics/features/nfp.ini         |   6 ++
>   doc/guides/rel_notes/release_22_11.rst   |   6 ++
>   drivers/net/nfp/flower/nfp_flower_cmsg.h |  11 +++
>   drivers/net/nfp/nfp_flow.c               | 112 +++++++++++++++++++++++++++++++
>   drivers/net/nfp/nfp_flow.h               |  37 ++++++++++
>   5 files changed, 172 insertions(+)
> 
> diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini
> index 4460cf0..194fe64 100644
> --- a/doc/guides/nics/features/nfp.ini
> +++ b/doc/guides/nics/features/nfp.ini
> @@ -29,3 +29,9 @@ Usage doc            = Y
>   [rte_flow items]
>   eth                  = Y
>   port_id              = Y
> +
> +[rte_flow actions]
> +count                = Y
> +dec_ttl              = Y
> +drop                 = Y
> +port_id              = Y

Are these actions supported? As far as I can see all done in the code is 
print log when these actions detected.

For 'dec_ttl' even logging seems missing.

I think better to document them as supported when actual support is added.

> diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
> index cd22d95..ac0223f 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -155,6 +155,12 @@ New Features
>   
>       * Ethernet
>   
> +  Add the support of rte_flow actions as follow:
> +
> +    * Count
> +    * Drop
> +    * TTL decrement

Not sure if this level of details is required in release notes, it can 
be sufficient that driver flow API support is added.