[PATCH v2 02/14] net/idpf/base: add logs and OS specific implementation
Guo, Junfeng
junfeng.guo at intel.com
Fri Oct 14 11:18:16 CEST 2022
> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> Sent: Monday, October 3, 2022 21:20
> To: Guo, Junfeng <junfeng.guo at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Xing,
> Beilei <beilei.xing at intel.com>
> Cc: dev at dpdk.org; Wang, Xiao W <xiao.w.wang at intel.com>
> Subject: Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific
> implementation
>
> On 9/5/22 13:58, Junfeng Guo wrote:
> > Add PMD logs.
> > Add some MACRO definations and small functions which are specific
> > for DPDK.
> >
> > Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> > Signed-off-by: Junfeng Guo <junfeng.guo at intel.com>
>
> The patch adds dead code as well. Added headers are used
> nowhere.
>
> One more question is what's the point to have two things in one
> patch? Typically such descriptions suggest that it could be
> separate patches in a right order.
Sure, will improve this in the coming version patchset. Thanks!
More information about the dev
mailing list