[PATCH v5 13/25] net/nfp: support SRC MAC flow action

[Ferruh Yigit]

On 10/20/2022 3:19 AM, Chaoyong He wrote:
> Add the corresponding data structure and logics, to support
> the offload of set source MAC action.
> 
> Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>

<...>

> +		case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC:
> +			PMD_DRV_LOG(DEBUG, "Process RTE_FLOW_ACTION_TYPE_SET_MAC_SRC");
> +			nfp_flow_action_set_mac(position, action, true, mac_set_flag);
> +			if (!mac_set_flag) {
> +				position += sizeof(struct nfp_fl_act_set_eth);
> +				mac_set_flag = true;
> +			}

Hi Andrew, Ori,

I can see 'RTE_FLOW_ACTION_TYPE_SET_MAC_SRC' and many  other marked as 
legacy and reference to 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD'.

What is the expectation from PMD developers for this?

User still can provide these legacy actions, right? So should PMD 
implement both legacy and new ones?