[PATCH v9 03/14] net/idpf: add queue setup and release in single queue model

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Fri Oct 21 09:44:21 CEST 2022


Just top level review for the rest of patches starting from
this one.

On 10/21/22 08:18, Junfeng Guo wrote:
> Add support for queue operations in single queue model:
>   - rx_queue_setup
>   - rx_queue_release
>   - tx_queue_setup
>   - tx_queue_release
> 
> In the single queue model, the same descriptor queue is used by SW to
> post buffer descriptors to HW and by HW to post completed descriptors
> to SW.
> 
> Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo at intel.com>
> ---
>   doc/guides/nics/features/idpf.ini |   2 +
>   doc/guides/nics/idpf.rst          |  22 ++
>   drivers/net/idpf/idpf_ethdev.c    |  58 ++++
>   drivers/net/idpf/idpf_ethdev.h    |   9 +
>   drivers/net/idpf/idpf_rxtx.c      | 465 ++++++++++++++++++++++++++++++
>   drivers/net/idpf/idpf_rxtx.h      | 186 ++++++++++++
>   drivers/net/idpf/idpf_vchnl.c     | 251 ++++++++++++++++
>   drivers/net/idpf/meson.build      |   1 +
>   8 files changed, 994 insertions(+)
>   create mode 100644 drivers/net/idpf/idpf_rxtx.c
>   create mode 100644 drivers/net/idpf/idpf_rxtx.h
> 
> diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features/idpf.ini
> index f029a279b3..681a908194 100644
> --- a/doc/guides/nics/features/idpf.ini
> +++ b/doc/guides/nics/features/idpf.ini
> @@ -7,6 +7,8 @@
>   ; is selected.
>   ;
>   [Features]
> +Runtime Rx queue setup = Y
> +Runtime Tx queue setup = Y

It does not make sense when device does not support start yet.
Typically it requies extra code to support runtime queues
setup. So, it is better to add the feature in a separate patch
after device start support.


>   Multiprocess aware   = Y
>   FreeBSD              = Y
>   Linux                = Y




More information about the dev mailing list