[PATCH v6 01/27] net/nfp: fix CPP bridge service requirement

Chaoyong He chaoyong.he at corigine.com
Fri Oct 21 10:01:37 CEST 2022


The CPP(Command Pull Push) bridge service is needed for some debug tools,
and should be optional, so remove the mandatory requirement of service
lcore parameter.

Fixes: b18804219537 ("net/nfp: add initial flower firmware support")

Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index f11a1b6..f25d6a1 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1066,11 +1066,8 @@
 
 	/* register the CPP bridge service here for primary use */
 	ret = nfp_enable_cpp_service(pf_dev->cpp);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "Enable cpp service failed.");
-		ret = -EINVAL;
-		goto hwqueues_cleanup;
-	}
+	if (ret != 0)
+		PMD_INIT_LOG(INFO, "Enable cpp service failed.");
 
 	return 0;
 
@@ -1208,13 +1205,6 @@
 		goto sym_tbl_cleanup;
 	}
 
-	/* Register the CPP bridge service for the secondary too */
-	ret = nfp_enable_cpp_service(cpp);
-	if (ret != 0) {
-		PMD_INIT_LOG(ERR, "Enable cpp service failed.");
-		ret = -EINVAL;
-	}
-
 sym_tbl_cleanup:
 	free(sym_tbl);
 
-- 
1.8.3.1



More information about the dev mailing list