[PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

[Thomas Monjalon]

17/10/2022 10:32, Andrew Rybchenko:
> On 10/6/22 21:35, Hanumanth Pothula wrote:
> > Presently, Rx metadata is sent to PMD by default, leading
> > to a performance drop as processing for the same in rx path
> > takes extra cycles.
> > 
> > Hence, introducing command line argument, 'nic-to-pmd-rx-metadata'
> > to control passing rx metadata to PMD. By default it’s disabled.
> > 
> > Signed-off-by: Hanumanth Pothula <hpothula at marvell.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> 
> Applied to dpdk-next-net/main, thanks.

I'm not sure this patch is really acceptable.
It is disabling Rx metadata by default just for benchmarking reason
because your driver is doing some processing even if metadata is not required.

From a user perspective, if a command requesting metadata is entered,
it won't work until we enable this new option on startup.
It looks terrible.

Please tell me I misunderstood something.