[PATCH v3 1/4] telemetry: support boolean type

Power, Ciara ciara.power at intel.com
Thu Oct 27 10:53:32 CEST 2022



> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson at intel.com>
> Sent: Tuesday 25 October 2022 11:39
> To: David Marchand <david.marchand at redhat.com>
> Cc: Mattias Rönnblom <hofors at lysator.liu.se>; dev at dpdk.org; Morten
> Brørup <mb at smartsharesystems.com>; Power, Ciara
> <ciara.power at intel.com>
> Subject: Re: [PATCH v3 1/4] telemetry: support boolean type
> 
> On Tue, Oct 25, 2022 at 11:43:27AM +0200, David Marchand wrote:
> > On Tue, Oct 25, 2022 at 11:34 AM Mattias Rönnblom
> <hofors at lysator.liu.se> wrote:
> > >
> > > On 2022-10-25 11:00, David Marchand wrote:
> > > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and
> dicts.
> > > >
> > > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > > Acked-by: Morten Brørup <mb at smartsharesystems.com>
> > > > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> > > > Acked-by: Ciara Power <ciara.power at intel.com>
> > > > ---
> > > > Changes since v1:
> > > > - fixed doxygen description,
<snip>
> > I'll let the telemetry maintainers decide on the fate of those patches.
> > Thanks.
> >
> Well, given the lateness in the release process, if it's a choice between
> getting the patches in as-is, vs not getting them in at all, I think having them
> in 22.11 is the better choice. While there is cleanup that can be done, I don't
> see this patch as making the overall code any worse.
> 
> My 2c.
> 
> /Bruce

Agreed, it's a good addition to the library, +1 to having it in 22.11

Thanks,
Ciara


More information about the dev mailing list