[Patch v7 01/18] net/mana: add basic driver, build environment and doc

Ferruh Yigit ferruh.yigit at xilinx.com
Tue Sep 6 15:01:35 CEST 2022


On 9/3/2022 2:40 AM, longli at linuxonhyperv.com wrote:

> 
> From: Long Li <longli at microsoft.com>
> 
> MANA is a PCI device. It uses IB verbs to access hardware through the
> kernel RDMA layer. This patch introduces build environment and basic
> device probe functions.
> 
> Signed-off-by: Long Li <longli at microsoft.com>
> ---
> Change log:
> v2:
> Fix typos.
> Make the driver build only on x86-64 and Linux.
> Remove unused header files.
> Change port definition to uint16_t or uint8_t (for IB).
> Use getline() in place of fgets() to read and truncate a line.
> v3:
> Add meson build check for required functions from RDMA direct verb header file
> v4:
> Remove extra "\n" in logging code.
> Use "r" in place of "rb" in fopen() to read text files.
> v7:
> Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap.
> 

Can you please check review comments on v4 [1], they seem still valid in 
this version.
I didn't go through other patches, but can you please double check 
comments on all v4 patches?


[1]
https://inbox.dpdk.org/dev/859e95d9-2483-b017-6daa-0852317b4a72@xilinx.com/



More information about the dev mailing list