[PATCH v8 04/12] net/nfp: add initial flower firmware support

[Ferruh Yigit]

On 9/8/2022 9:44 AM, Chaoyong He wrote:
> Adds the basic probing infrastructure to support the flower firmware.
> 
> Adds the basic infrastructure needed by the flower firmware to operate.
> The firmware requires threads to service both the PF vNIC and the ctrl
> vNIC. The PF is responsible for handling any fallback traffic and the
> ctrl vNIC is used to communicate various control messages to and
> from the smartNIC. rte_services are used to facilitate this logic.
> 
> Adds the cpp service, used for some user tools.
> 
> Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
> ---
>   doc/guides/rel_notes/release_22_11.rst |  3 ++

Can you please update driver documentation too, 
'doc/guides/nics/nfp.rst', to document these new features?
Please update it gradually in each relevant patch, as you are already 
doing for release notes updates.

>   drivers/net/nfp/flower/nfp_flower.c    | 59 +++++++++++++++++++++++
>   drivers/net/nfp/flower/nfp_flower.h    | 18 +++++++
>   drivers/net/nfp/meson.build            |  1 +
>   drivers/net/nfp/nfp_common.h           |  1 +
>   drivers/net/nfp/nfp_cpp_bridge.c       | 87 +++++++++++++++++++++++++++++-----
>   drivers/net/nfp/nfp_cpp_bridge.h       |  6 ++-
>   drivers/net/nfp/nfp_ethdev.c           | 28 ++++++++++-
>   8 files changed, 187 insertions(+), 16 deletions(-)
>   create mode 100644 drivers/net/nfp/flower/nfp_flower.c
>   create mode 100644 drivers/net/nfp/flower/nfp_flower.h
> 
> diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
> index f601617..bb170e3 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -55,6 +55,9 @@ New Features
>        Also, make sure to start the actual text at the margin.
>        =======================================================
>   
> +   * **Updated Netronome nfp driver.**

This is still in the section comment, need to fix the indentation to 
move it out of comment.

And please put an empty line after this line.

Please compile and verify the documentation updates.

> +     Added the support of flower firmware.
> +     Added the flower service infrastructure.

In output these lines are joined, if the intentions is have them as 
bullets, need to add '*' prefix, like:
```
  * **Updated Netronome nfp driver.**

      * Added the support of flower firmware.
      * Added the flower service infrastructure.
      * Added the control message interactive channels between PMD and 
firmware.
      * Added the support of representor port.
```