[PATCH v2 3/6] app/procinfo: add module info dump

Stephen Hemminger stephen at networkplumber.org
Tue Sep 20 17:22:29 CEST 2022


On Tue, 20 Sep 2022 18:51:44 +0800
Dongdong Liu <liudongdong3 at huawei.com> wrote:

> +
> +	RTE_ETH_FOREACH_DEV(i) {
> +		/* Skip if port is not in mask */
> +		if ((enabled_port_mask & (1ul << i)) == 0)
> +			continue;
> +
> +		if (!rte_eth_dev_is_valid_port(i))
> +			continue;

There is no way RTE_ETH_FOREACH_DEV would iterate
over an invalid port.  If it did the macro would be seriously
broken.

That code is unnecessary.


More information about the dev mailing list