[PATCH] net/nfp: improve readability NFP HWINFO header

Ferruh Yigit ferruh.yigit at xilinx.com
Tue Sep 20 19:33:02 CEST 2022


On 8/26/2022 6:39 AM, Chaoyong He wrote:
> From: James Hershaw <james.hershaw at corigine.com>
> 
> Prepend `0x` to the NFP HWINFO header value that is printed to improve
> the readability of the printed statement.
> 
> Signed-off-by: James Hershaw <james.hershaw at corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
> ---
>   drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> index c0516bf..9f848bd 100644
> --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c
> @@ -108,7 +108,7 @@
>   		goto exit_free;
>   
>   	header = (void *)db;
> -	printf("NFP HWINFO header: %08x\n", *(uint32_t *)header);
> +	printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header);

Why driver is directly using 'printf', but not rte_log APIs?

I can see there are already 'PMD_INIT_LOG' & 'PMD_DRV_LOG' macros for this.



More information about the dev mailing list