[PATCH v2 2/6] app/procinfo: add RSS RETA dump
Dongdong Liu
liudongdong3 at huawei.com
Wed Sep 21 13:21:55 CEST 2022
On 2022/9/20 23:24, Stephen Hemminger wrote:
> On Tue, 20 Sep 2022 18:51:43 +0800
> Dongdong Liu <liudongdong3 at huawei.com> wrote:
>
>> + ret = rte_eth_dev_info_get(id, &dev_info);
>> + if (ret < 0) {
>> + printf("Error getting device info, ret = %d\n", ret);
>
> Proc-info should be showing all errors on stderr, not stdout.
> And in case of error should exit with non-zero status.
Will fix as below code.
ret = rte_eth_dev_info_get(i, &dev_info);
if (ret != 0) {
fprintf(stderr, "Error during getting device
info: %s\n",
strerror(-ret));
return;
}
>
> But this maybe a generic problem in lots of places in the application.
Yes, we can do this later with a seperate patch.
Thanks,
Dongdong
> .
>
More information about the dev
mailing list