[PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200

[Chautru, Nicolas]

Hi Maxime, 

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Wednesday, September 21, 2022 12:18 AM
> To: Chautru, Nicolas <nicolas.chautru at intel.com>; dev at dpdk.org;
> thomas at monjalon.net
> Cc: trix at redhat.com; mdr at ashroe.eu; Richardson, Bruce
> <bruce.richardson at intel.com>; hemant.agrawal at nxp.com;
> david.marchand at redhat.com; stephen at networkplumber.org; Vargas,
> Hernan <hernan.vargas at intel.com>
> Subject: Re: [PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200
> 
> 
> 
> On 9/16/22 03:34, Nic Chautru wrote:
> > From: Nicolas Chautru <nicolas.chautru at intel.com>
> >
> > This patch introduce stubs for device driver for the ACC200 integrated
> > VRAN accelerator on SPR-EEC
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru at intel.com>
> > ---
> >   MAINTAINERS                              |   3 +
> >   doc/guides/bbdevs/acc200.rst             | 244
> +++++++++++++++++++++++++++++++
> >   doc/guides/bbdevs/index.rst              |   1 +
> >   drivers/baseband/acc200/acc200_pmd.h     |  32 ++++
> >   drivers/baseband/acc200/meson.build      |   6 +
> >   drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++
> >   drivers/baseband/acc200/version.map      |   3 +
> >   drivers/baseband/meson.build             |   1 +
> >   8 files changed, 432 insertions(+)
> >   create mode 100644 doc/guides/bbdevs/acc200.rst
> >   create mode 100644 drivers/baseband/acc200/acc200_pmd.h
> >   create mode 100644 drivers/baseband/acc200/meson.build
> >   create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c
> >   create mode 100644 drivers/baseband/acc200/version.map
> 
> This is not how the common code sharing rework should be done. It does not
> make sense to introduce acc200 directory in patch 2 to move it to acc in
> patch 12.
> 
> The series must follow a logical path, by first refactoring acc100 to share
> common code and then to add acc200 by making directly use of this
> common code.

OK sure. I was hoping I could avoid having to rebase all these commits but I will update now in the v4. 

> 
> Regards,
> Maxime