[PATCH] ethdev: rte_eth_rx_queue_count is a dataplane function

Morten Brørup mb at smartsharesystems.com
Thu Sep 22 15:46:34 CEST 2022


> From: Andrew Rybchenko [mailto:andrew.rybchenko at oktetlabs.ru]
> Sent: Monday, 12 September 2022 16.47
> 
> On 8/18/22 15:23, Ferruh Yigit wrote:
> > On 8/18/2022 10:37 AM, Morten Brørup wrote:
> >> Applications may use rte_eth_rx_queue_count() in the RX stage of the
> >> dataplane, so only check the function parameters if built with
> >> RTE_ETHDEV_DEBUG_RX.
> >>
> >> Signed-off-by: Morten Brørup <mb at smartsharesystems.com>
> >
> > I don't remember if those checks done by default intentionally, but I
> > don't think so,
> >
> > And since other relevant functions do the same thing:
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit at xilinx.com>
> >
> 
> The patch itself looks good to me.
> Summary should be fixed to be not a statement and should not
> mention function name.

Please feel free to fix when merging. :-)

> Other than that:
> 
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>

Thank you.

-Morten



More information about the dev mailing list