[PATCH v3 1/9] net/gve: introduce GVE PMD base code

Guo, Junfeng junfeng.guo at intel.com
Tue Sep 27 09:27:45 CEST 2022



> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Saturday, September 24, 2022 02:58
> To: Guo, Junfeng <junfeng.guo at intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>; ferruh.yigit at xilinx.com; dev at dpdk.org; Li,
> Xiaoyun <xiaoyun.li at intel.com>; awogbemila at google.com; Richardson,
> Bruce <bruce.richardson at intel.com>; Lin, Xueqin <xueqin.lin at intel.com>;
> Wang, Haiyue <haiyue.wang at intel.com>
> Subject: Re: [PATCH v3 1/9] net/gve: introduce GVE PMD base code
> 
> On Fri, 23 Sep 2022 17:38:21 +0800
> Junfeng Guo <junfeng.guo at intel.com> wrote:
> 
> > +#define GVE_DEVICE_OPTION_TOO_BIG_FMT "Length of %s option
> larger than expected. Possible older version of guest driver."
> 
> Why do you need #define for this?

This macro is used by gve kernel driver and we just keep it here. Thanks!

> 
> +#define GVE_DEVICE_OPTION_ERROR_FMT "%s option error:\n" \
> +"Expected: length=%d, feature_mask=%x.\n" \
> +"Actual: length=%d, feature_mask=%x."
> +
> 
> Why such a wordy multi-line message, please use single line

This one is also from gve kernel driver.
Will update with single line message in the coming version.
Thanks!


More information about the dev mailing list