[EXT] Re: [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes

[Akhil Goyal]

> 24/09/2022 15:57, Akhil Goyal:
> > From: Vamsi Attunuru <vattunuru at marvell.com>
> >
> > Patch adds new event subtypes for notifying expiry
> > events upon reaching IPsec SA soft packet expiry and
> > hard packet/byte expiry limits.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>
> > Signed-off-by: Akhil Goyal <gakhil at marvell.com>
> > ---
> > --- a/lib/ethdev/rte_ethdev.h
> > +++ b/lib/ethdev/rte_ethdev.h
> > @@ -3875,8 +3875,26 @@ enum rte_eth_event_ipsec_subtype {
> >  	RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW,
> >  	/** Soft time expiry of SA */
> >  	RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
> > -	/** Soft byte expiry of SA */
> > +	/**
> > +	 * Soft byte expiry of SA determined by @ref bytes_soft_limit
> > +	 * defined in @ref rte_security_ipsec_lifetime
> > +	 */
> >  	RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> > +	/**
> > +	 * Soft packet expiry of SA determined by @ref packets_soft_limit
> > +	 * defined in @ref rte_security_ipsec_lifetime
> > +	 */
> > +	RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
> > +	/**
> > +	 * Hard byte expiry of SA determined by @ref bytes_hard_limit
> > +	 * defined in @ref rte_security_ipsec_lifetime
> > +	 */
> > +	RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY,
> > +	/**
> > +	 * Hard packet expiry of SA determined by @ref packets_hard_limit
> > +	 * defined in @ref rte_security_ipsec_lifetime
> > +	 */
> > +	RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY,
> >  	/** Max value of this enum */
> >  	RTE_ETH_EVENT_IPSEC_MAX
> 
> I would prefer we remove this MAX value, but it would be another patch.
> 
> Acked-by: Thomas Monjalon <thomas at monjalon.net>
> 
> You can merge this patch in the crypto tree.
> 
Series Applied to dpdk-next-crypto